-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement authority
module
#1815
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1815 +/- ##
===========================================
- Coverage 39.92% 33.36% -6.57%
===========================================
Files 206 130 -76
Lines 12617 9205 -3412
===========================================
- Hits 5037 3071 -1966
+ Misses 7183 5909 -1274
+ Partials 397 225 -172
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, couple smaller comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments
Co-authored-by: Tanmay <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Seems like there is bug with Codecov, the diff coverage is -6% while the new addition is almost fully covered, will merge and check if there is a bug, otherwise gonna see what's wrong |
Description
authority
module containing objectPolicies
matching address with policy typesIsAuthorized
for better unit testingobserver.Params
->authority.Policies
UpdatePolicies
message to update the policies.Closes: #1714